Hi Colin,

You described the exact process I want to follow.  I suppose I used the word
"pre-commit" too loosely.  What I meant is pre committing to the central
repo.  Thanks for the tip!

Jason

On Tue, Aug 4, 2009 at 1:13 AM, Colin Caughie <c.caug...@indigovision.com>wrote:

>  Just curious; why do you need pre-commit code reviews? I can understand
> wanting to do that if you were using a centralized VCS like Subversion, but
> with Mercurial committing to your local repo doesn't affect anyone else
> (until you push) and moreover doing this gives you a record of the code as
> it was when it was submitted for review.
>
>
>
> Our own process is:
>
>
>
> 1. Commit change locally
>
> 2. Post review request using "hg postreview" (see
> http://mercurial.selenic.com/wiki/ReviewboardExtension)
>
> 3. After receiving comments, make changes in a new changeset.
>
> 4. If desired, use "hg collapse" or "hg histedit" to combine all changesets
> relating to the task into one
>
> 5. Push to the master repo.
>
>
>
> Colin
>
>
>
> *From:* Jason Wang [mailto:ja...@scorebig.com]
> *Sent:* 03 August 2009 06:27
> *To:* tortoisehg-discuss@lists.sourceforge.net
> *Subject:* [thg] Ways to create unified diffs
>
>
>
> Hi All,
>
> Is there a way to create unified diffs before any commits?  The only way I
> know of is through the changelog window after the code has been commited.  I
> want to incorporate code review (using Review Board) in our dev process with
> pre-commit code reviews.
>
> Any tips would be great.
>
> Thanks,
>
> Jason
>  ------------------------------
>
> *scanned for viruses and spam by **indigovision
> *If you consider this email spam, please forward to
> s...@emailfiltering.com
>
> Latest News at: http://www.indigovision.com/news2009.php
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Tortoisehg-discuss mailing list
Tortoisehg-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss

Reply via email to