On Fri, Aug 14, 2009 at 5:49 PM, Adrian Buehlmann<adr...@cadifra.com> wrote: > On 14.08.2009 21:54, Steve Borho wrote: >> In 0.8, the first opened dialog window is considered the 'main app' >> and when that app is closed every window that was spawned from that >> app is closed. I find this disconcerting at times. > > seconded > >> On the default branch I'm thinking of maintaining a list of opened >> "apps" and closing them all on 'CTRL-Q' but making none of them >> particularly special. There will still be the concept of "application >> groups", CTRL-Q will only close apps that were opened by a single hgtk >> instance. If you run hgtk log then hgtk ci, doing a CTRL-Q in one >> will not close the other. >> >> We'll be tying more apps together in 0.9. You'll be able to get to >> the "top 4" (commit, log, datamine, synch) no matter which one was >> initially launched, and that will probably limit the amount of hgtk >> instances you typically run. So maybe that's not a big deal. > > Hmm. I've never used CTRL-Q. > > I don't know how complicated things are, but if it is doable without > doing contortions in the code I would keep the major dialogs > completely independent. I wouldn't even mind if you'd spawn > each major dialog in its own process. > > For example, if I look at that 'Changelog' button I'm trying to > add to the commit dialog right now, I think clicking that button > could be equivalent to launching the dialog from the context menu, > that is, it could spawn its own process. > > If I click the 'Changelog' button in the commit window, I immediately > forget that I launched the log viewer from the commit window. > So I would be surprised if the log is closed when I do CTRL-Q in > the commit window. > > Imagine, I can have multiple log windows open. Some started from > the 'Changelog' button in a commit window (I can actually have > multiple commit windows open at the same time. Think of starting them > in different repos by using the cmenu). Sure I then can't > tell anymore what belongs together. > > So, unless I have misunderstood something, I think "application > groups" aren't helpful. > > Also, the user has no visual clue what belongs to what. I can launch > all major thg windows independently from the cmenu. Every window > gets a separate entry in the taskbar. And if I do Ctrl-Q on one > of them, I'd expect only that one to quit.
It is very tempting to do this. It would prevent a lot of side effects. I can tell you why we haven't done this yet, and it has to do with notifications. When the dialogs are within the same process they can notify each other when things happen. Grep for 'notify_func' to find all the places this is used. Mostly this is for helper dialogs, but it is used between the larger applications in a few places. Synch notifies changelog when changes are pulled. Commit notifies changelog when a merge commit is complete. Perhaps we can resolve these inconsistencies. -- Steve Borho ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Tortoisehg-discuss mailing list Tortoisehg-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
