On Mon, Nov 30, 2009 at 12:23 AM, Олег Тазетдинов <ton1...@mail.ru> wrote: >> Steve Borho wrote: >> > I'm looking for feedback about including a small lightweight editor >> > with the TortoiseHg Windows installer that we can set as the default >> > visual editor. The main reason for this is notepad.exe cannot read >> > unix eoln files, and it would be nice if our default editor handled >> > unicode and had at least some simple syntax highlighting. >> > >> > The two obvious candidates are Notepad2 and Notepad++, both are free >> > software. >> > > I do not think the editor is necessary. > > People who mostly deal with Windows development do not have the problem of > reading unix eoln files, they use Windows eoln and can use any Windows editor > (even notepad that is quite good for small things like a commit message). > > On the other hand people who do development under both Windows and Linux most > likely will use win32text extension to keep their eoln native to the current > OS. That is really how I do it since most of my project have to be portable > across Windows and Unix and that is why I was so glad when eoln handling had > finally been incorporated into both Mercurial and TortoiseHg. > > Personally I use Crimson Editor for small file editing but still the files in > my working directory always have eoln corresponding to the operating system > (thanks again to win32text extension). > > BTW, when I tried to use Crimson Editor for commit message editing when using > CLI under Windows it turned out it's not possible since for some reason > Mercurial could not detect when Crimson Editor process finished so now I am > sticking to Notepad.
Yep, this is the same process forking issue that gives extdiff such headaches. If you launch Crimson Editor from the command line, it will become obvious why it does not work with Mercurial. The initial process forks a second process to open the GUI and then exits immediately. MacOS's text editor does the same thing. You essentially have to wrap the editor in a script that waits until the editor is really closed before returning control back to Mercurial. -- Steve Borho FWIW: I'm leaning towards not bundling an editor. But it's becoming ever more apparent that a "first time" wizard would be extremely useful. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Tortoisehg-discuss mailing list Tortoisehg-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
