On Sun, Dec 20, 2009 at 04:31, Adrian Buehlmann <adr...@cadifra.com> wrote: > I disagree with this change in the default branch: > > changeset: 5226:00c3b466f8ff > user: Yuki KODAMA <endflow....@gmail.com> > date: Sat Dec 19 16:53:08 2009 +0900 > summary: history: cleanup syncbar buttons > > http://bitbucket.org/tortoisehg/stable/changeset/00c3b466f8ff/ > > It has been pushed to the default branch (which will be included in 0.10). > > This change makes the stop button invisible, if there is nothing to stop. > > This is very bad ui design. > > If there is a stop button in the toolbar, it must be visible all the time, > not just during the few seconds while an operation is running. > > Having the rest of the ui elements in the toolbar jumping left and right > is unacceptable. > > Please backout this change. > > The previous state of the code just disabled inapplicable buttons > in the syncbar, which was perfectly fine.
Hmm... you didn't describe why it's *very* bad ui. Or you just want to see Stop button always? If you so, I'm okay to change the sensitive of Stop button instead of changing visibility :) The changeset contains changes for Apply/Reject/Stop buttons. However, you mentioned nothing about Apply/Reject buttons. Does this means that you disagree just Stop button? -- Yuki KODAMA ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Tortoisehg-discuss mailing list Tortoisehg-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
