On Thu, Apr 1, 2010 at 11:06 PM, Yuki KODAMA <[email protected]> wrote:
> On Fri, Apr 2, 2010 at 13:39, Steve Borho <[email protected]> wrote:
>> On Thu, Apr 1, 2010 at 11:28 PM, Yuki KODAMA <[email protected]> wrote:
>>> On Fri, Apr 2, 2010 at 13:21, Mark Tolonen <[email protected]> wrote:
>>>>> I installed 1.0.1 to Windows XP 32-bit box.
>>>>> But the installer appends "C:\Program Files\TortoiseHg\" to PATH
>>>>> environment variable,
>>>>> not "C:\Program Files\TortoiseHg".  As a result, we can't use "hg"
>>>>> command via Windows
>>>>> command prompt.
>>>>
>>>> It works either way.  I have Windows XP and the same PATH entry and it
>>>> works.
>>>>
>>>> Windows doesn't care if you put multiple backslashes in a row, e.g., this
>>>> works:
>>>>
>>>> dir "C:\Program Files\\\\\\\TortoiseHg\\\\\\\\\\\\\\\\\\\"
>>>>
>>>> (although it *is* picky about only a single one after the colon, at least 
>>>> on
>>>> XP)
>>>
>>> Yeah, you're right, Mark.  Thanks for replying.
>>> This is trivial issue, we won't need to ship 1.0.1-1 (installer fix 
>>> version).
>>> But if possible, I hope this issue will be fixed for 1.0.2.
>>
>> (dropping hg-user mailing list)
>>
>> Phew.  I was quite curious about this because the PATH mechanism
>> hasn't changed since 1.0. The trailing slash is a side-effect of the
>> way Windows Installer treats directory variables; it always appends
>> the trailing slash for easy concatenation.  I'm not sure if there's an
>> easy way to strip it.
>
> Does 1.0 installer append trailing backslash to PATH?
> WiX source codes were changed very often, so I couldn't follow all of them.

1.0:
            <Environment Id="Environment" Name="PATH" Part="last" System="yes"
                         Permanent="no" Value="[INSTALLDIR]" Action="set" />

1.0.1:
            <Environment Id="Environment" Name="PATH" Part="last" System="yes"
                         Permanent="no" Value="[INSTALLDIR]" Action="set"
            />

--
Steve

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Tortoisehg-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss

Reply via email to