On Thursday, October 26, 2017 at 6:17:37 PM UTC+2, Julian Foad wrote: > > We copied TSVN source code into a git repo and then tried to build. It > failed on the step where 'versioninfo.build' runs SubWCRev to try to > construct a version number from the Subversion revision number. > > It already bypasses this step and uses the result '0' (zero) if SubWCRev > tool is not available. I changed it to also bypass this step if SubWCRev > tool returns an error. (See diff below.) > > I think it is useful to be able to move the source code to a different VCS > and still work with it. This is one of only two issues with building > outside an svn WC. (The other is the use of svn externals. I might send a > separate message about how we are working around that.) > > Would you be interested in having this change in the main code? >
Change looks good, but you should also disable the 'msi' target if SubWCRev fails for some reason. Because if there is no svn revision to use and zero is assumed instead, the msi installer will fail to update an already installed TSVN properly. So it's then best to just not build the msi at all. Stefan -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/0bd8017d-483c-4ca2-86e0-f05f5922188c%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
