On Friday, November 3, 2017 at 12:05:52 PM UTC+1, Konrad Zuwała wrote: > > Hey guys! > > I need some help with custom installers. > > As agreed we will have two 'versions' of tortoise. One official, from > trunk, and one built from shelve branch. >
Do we really need two versions? What's stopping you from merging the shelving stuff in the svn repository back to trunk? From what I can see, it's pretty stable already, and most importantly even if it's not stable it wouldn't affect any existing features. If you can't merge those back on the svn trunk, then maybe we could switch the TSVN trunk to link to the svn shelve branch instead, and you could merge your TSVN shelve branch back to trunk. The TSVN nightly builds are there for a reason: to test out new features and get feedback. And as I said: those are new commands which won't affect any existing features users might depend on. So it's safe to include those in the nightly builds. > Now, I have a few questions about that solution: > 1. Is it OKish solution or it's totally stupid what I did? :D That's like > the most important question :) > I would just create the installer identical to what we do now. You can't really have two TSVN versions installed at the same time, that would be really confusing. One install should just overwrite the other. > 2. I changed upgrade GUID for the new app, by randomizing a bit Tortoise > SVN upgrade GUIDs. Is it fine or GUIDs are generated totally different way? > In Visual Studio, Menu "Tools", then "Create Guid" - that will start a tool to generate GUIDs. > 3. In order to make solution complete, we need to have official > TortoiseSVN installer be able to detect Shelve version (so it doesn't > install next to Shelve version of TortoiseSVN). So I bet we need to make > changes in official 'trunk' installer too? > 4. Maybe you have any suggestions regarding how it's better to do it? Like > for instance I tried to experiment with detection of official TSVN upgrade > GUIDs and, based on that, doing installation or aborting it. But it seemed > for me that registry key/value is the best solution I can come up with. > Why not just skip all that and just make a 'normal' installer? * if TSVN is installed, it will be overwritten (shelve versions are usually newer than the latest release) * if user want's to go back to the official release or a nightly build, first uninstalling the 'newer' version and then installing the 'older' version isn't too much work and this would also avoid any problems with multiple entries in the "installed programs" listing Stefan -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/5a5cfdad-b3bc-492f-bce2-2e5fc6df6a60%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
