Hi, When the registry key "HKCU\Software\TortoiseSVN\CommitReopen" is set to "1", then the Copy dialog will reopen in case the commit failed. If this happens and the repository contains externals, then the list of externals will display all externals multiple times, as the externals vector is not getting cleared before it's being repopulated.
The attached patch fixes that by first clearing the externals vector. The issue was found in 1.9.7, but applies to 1.10.0 and trunk, as well. It would be nice if it was applied to all three branches. Thanks and regards Patrick -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/20180514100305.GA4512%40ncase. For more options, visit https://groups.google.com/d/optout.
Index: src/TortoiseProc/CopyDlg.cpp
===================================================================
--- src/TortoiseProc/CopyDlg.cpp (revision 28126)
+++ src/TortoiseProc/CopyDlg.cpp (working copy)
@@ -315,6 +315,7 @@
CTSVNPath retPath;
svn_client_status_t * s = NULL;
m_maxrev = 0;
+ m_externals.clear();
s = stats.GetFirstFileStatus(m_path, retPath, false,
svn_depth_unknown, true, true);
if (s)
{
signature.asc
Description: PGP signature
