måndag 5 december 2022 kl. 18:49:13 UTC+1 skrev Stefan:

> On Sunday, December 4, 2022 at 11:23:50 AM UTC+1 daniel.l...@gmail.com 
> wrote:
>
>> lördag 3 december 2022 kl. 20:38:35 UTC+1 skrev Daniel Sahlberg:
>> [...]
>>
>>> +                if ((pItem->lastHead != item.lastHead) || 
>>> (pItem->lastErrorMsg.IsEmpty() != item.lastErrorMsg.IsEmpty()))
>>>
>>
>> On second thoughts, this is probably not the best solution. If there was 
>> an old error message and another error occurs, it will not be updated. Thus 
>> it should probably be
>> [[[
>> +                if ((pItem->lastHead != item.lastHead) || 
>> (pItem->lastErrorMsg != item.lastErrorMsg))
>> ]]]
>>
>
> this looks very good! Please commit.
>

Thanks. I was mostly worried there was a design decision not to remove the 
error status. Committed as r29490.
 

> It seems I can retire now :)
>

Please don't!  I'm sure you've forgotten more about Subversion than I will 
ever learn. :-)

Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a4d6b5bc-8cb5-4adb-b829-86bfba147d3bn%40googlegroups.com.

Reply via email to