måndag 29 maj 2023 kl. 16:39:28 UTC+2 skrev Denis Kovalchuk: Hi!
I am wondering if there are any reasons to build OpenSSL with the '-no-asm' [1][2] option? Below are the results of synthetic benchmarks for Subversion, depending on whether OpenSSL is built with or without asm support: 1) OpenSSL is built with the ‘-no-asm’ option. svnbench null-export https://localhost/svn/iso/~7GB.iso 0 directories 1 files 7,395,016,704 bytes in files 0 properties 0 bytes in properties 50.812102 seconds taken 7,404,963,366 bytes transferred over network 2) OpenSSL is built without the ‘-no-asm’ option. svnbench null-export https://localhost/svn/iso/~7GB.iso 0 directories 1 files 7,395,016,704 bytes in files 0 properties 0 bytes in properties 17.406729 seconds taken 7,404,963,353 bytes transferred over network This ~3x improvement is well observed when dealing with localhost, where the network bandwidth is high enough. Very interesting results. Did you run this on a build from /trunk/ - ie with OpenSSL 3.1? The no-asm seems to be added in r18542 (2010-02-06), with the comment "Update to OpenSSL 1.0.0 beta 5". I've searched the mailing lists (https://svn.haxx.se/tsvn/) and couldn't find a motivation why no-asm was required. The OpenSSL INSTALL.md notes: [[[ ### no-asm Do not use assembler code. This should be viewed as debugging/troubleshooting option rather than for production use. On some platforms a small amount of assembler code may still be used even with this option. ]]] So I would like to suggest enabling asm support for OpenSSL, unless of course there is a reason to build OpenSSL with the '--no-asm' option. Note that this change requires NASM [3] to build TortoiseSVN. Considering the OpenSSL documentation suggest that no-asm is a debug-ish option, I'm +0 for removing it. I didn't try to build it yet, but I will do this as time permits. I'd like to note that we need to get NASM installed on the nightly-build machines. Kind regards, Daniel Sahlberg -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/ea5ffbc9-60be-493d-a44a-6bd9efecb7ddn%40googlegroups.com.
