After installing a new version of TSVN (1.13.1) on a new laptop, I noticed 
that if I try to show the log for a folder or file that has Hebrew 
characters in it, the request fails like this:

   1. The log window appears.
   2. I get the "Want to go offline?" modal dialog, which says "There has 
   been a problem contacting the server".
   3. I cancel it and it appears again after a couple of seconds.
   4. I cancel it again and then the log window shows the error message 
   "Unable to connect to a repository at URL 'XXX' in the revision section
   
The problem with the URL appears to be that the space in the repo name (and 
only that space) is escaped as %2520 instead of %20, like all the other 
spaces in the URL.

Simplified example using a local repository with the file protocol, 
although my actual use is with HTTP:

[image: tsvn error.png] <about:invalid#zClosurez>


















This only happens if the repo has a space in its name and if the item I 
click has Hebrew somewhere in the URL (the Hebrew characters themselves are 
escaped as %D7%90 through %D7%AA, which doesn't actually seem to be a valid 
range for Unicode, but seems to work correctly and has done so for years). 
I haven't tested other languages.

The same issue happens if I ask for the log from the repo browser.

If I right click the file/folder in either window and ask to copy the URL 
to the clipboard, it is copied with the space correctly escaped as %20.

I haven't noticed anything else which is affected by this so far, other 
than logs. Updates, commits and diffs work correctly, even when applied 
directly to the file. Logs also show the file correctly if the log is 
performed on a higher level in the folder structure, where there is no 
Hebrew.

I haven't seen this issue before now because for the last few years I was 
using an older version of TSVN (1.9.3 27038 on Windows 10), which doesn't 
have this issue. I do see the issue on PCs with Windows 10 and TSVN version 
1.9.5 build 27581, so I assume it was introduced somewhere in between those 
two versions. 

After uninstalling version 1.9.5 on one of those PCs and installing 1.9.3, 
it seems to work correctly. I might do that for now or resort to not 
showing logs directly on things with Hebrew in them.


Probably minor point - when I set up the example shown above, I created two 
repos (called "repo" and "space repo") and did see that this only happened 
on the space repo, but when playing around with it I also managed to get it 
to a point where it did work correctly even on the space repo. I'm not sure 
what the exact steps were that led to that. This didn't cause other repos 
to work correctly and I didn't check if it survived a system reboot or 
anything like that. I did see that even when the space repo worked 
correctly, the real repo I use still didn't work correctly.


Here are some Hebrew characters, if anyone wants to try to reproduce:

אבגדהוזחטי

You could probably also install a Hebrew language pack on Windows and use 
the on screen keyboard, and I assume Mac and Linux also have support.


Thanks.

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn/ddd7eae7-0014-4cb9-8484-9c18f3e070a6%40googlegroups.com.
  • TSVN fail... Yair via TortoiseSVN
    • Re: ... Stefan via TortoiseSVN
      • ... tortoisesvn+APn2wQdgoGgtrtBYZOi8J-oxwPu3g9pu2P9F79W2sgmvXKuz4iNz
        • ... Stefan via TortoiseSVN
          • ... tortoisesvn+APn2wQdgoGgtrtBYZOi8J-oxwPu3g9pu2P9F79W2sgmvXKuz4iNz
            • ... TortoiseSVN
              • ... TortoiseSVN
                • ... Stefan via TortoiseSVN
                • ... TortoiseSVN

Reply via email to