In chrome, an entry is added/updated in the history database in HistoryTabHelper::DidNavigateAnyFrame(), which is called by content::WebContents::DidNavigateAnyFramePostCommit(), which itself is called by content::NavigatorImpl::DidNavigate(). This corresponds to a LoadCommitted event in oxide.
LoadCommitted events emitted by oxide originate from content::WebContents::DidCommitProvisionalLoad(), which is called by content::NavigatorImpl::DidNavigate(). This confirms that we should indeed store entries in the shared history when getting LoadCommitted events, not LoadSucceeded. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to webbrowser-app in Ubuntu. https://bugs.launchpad.net/bugs/1455858 Title: History AWOL with YouTube "get more videos" button. Status in Oxide: Invalid Status in webbrowser-app: Invalid Status in webbrowser-app package in Ubuntu: In Progress Bug description: Nexus 7 2013, Ubuntu Touch r2, dev channel. There appears to be a browser bug, possibly connected to the YouTube "get more videos" button at the bottom of a page. When the button is pressed, no history is remembered and the video plays without a chance to choose whether HQ or not. To manage notifications about this bug go to: https://bugs.launchpad.net/oxide/+bug/1455858/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
