Without further investigation, the following patch fixes 3 of the 4
failures (I haven’t checked whether it doesn’t break other things in the
UITK though):
=== modified file 'src/Ubuntu/Components/plugin/privates/listviewextensions.cpp'
--- src/Ubuntu/Components/plugin/privates/listviewextensions.cpp
2016-03-01 15:08:08 +0000
+++ src/Ubuntu/Components/plugin/privates/listviewextensions.cpp
2016-03-08 09:55:06 +0000
@@ -141,11 +141,12 @@
int currentIndex = this->currentIndex();
int count = this->count();
+ int oldIndex = currentIndex;
if (currentIndex >= 0 && count > 0) {
currentIndex = qBound<int>(0, forwards ? currentIndex - 1 :
currentIndex + 1, count - 1);
setCurrentIndex(currentIndex);
setKeyNavigationForListView(true);
}
- return true;
+ return (oldIndex != currentIndex);
}
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in
Ubuntu.
https://bugs.launchpad.net/bugs/1554447
Title:
4 webbrowser-app unit test failures with staging UITK
Status in ubuntu-ui-toolkit package in Ubuntu:
New
Status in webbrowser-app package in Ubuntu:
New
Bug description:
Running webbrowser-app’s unit tests with the latest staging branch of
the UITK as of today (lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at
revision 1885), I’m seeing 4 unit test failures (see full log
attached).
Looking into those failures, it appears that they all have the same
root cause: they expect a KeyUp/KeyDown event to transfer active focus
from a listview to another element, and that doesn’t happen.
https://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-
toolkit/staging/revision/1878 looks like a likely culprit. In
particular, ListViewProxy::keyPressEvent() always returns true, even
if the event didn’t actually result in an index change.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1554447/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
