I understand it's the expected outcome, but why was it changed? None of the bugs which the MP claimed to fix require this change. Actually, if you look at line 209 of the diff (at https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/invisible-header-topmargin/+merge/290659) you'll see that a unit test was changed to accommodate for this behavioural change. Which proves that there has been a behavioural change in the first place. :-)
Why do we need to *sum* the header's height to the flickable.topMargin? I think that the correct solution should be to *replace* the flickable.topMargin with the header height, while the header is active on the flickable. I don't see any reason why the two values should be summed. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1572525 Title: [regression] Double header height is set as flickable topMargin Status in Canonical System Image: Incomplete Status in ubuntu-ui-toolkit package in Ubuntu: New Bug description: Th attached test application works fine under qml-module-ubuntu- components 1.3.1918+16.04.20160404-0ubuntu3 but breaks with the latest 1.3.1938+16.04.20160416. At a first examination, I believe that the change which cause the regression is this one: https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/invisible- header-topmargin/+merge/290659 Run the attached test case with QML scene. You can scroll the view horizontally to see the other model items. Under the old version of the toolkit, all items have their page headers correctly aligned; with the new version, an extra spacing is added below the header. I found this bug while testing my ttrss app in rc-proposed; please don't let this UITK version reach our users, as more apps might be affected. To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1572525/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
