I've uploaded the patch in comment #3 to xenial.  I've also added some
SRU bits to the description -- if either Robie or Philip could maybe add
some test case steps, that would be swell.  Thanks!

** Description changed:

  In 1:4.2.8p3+dfsg-1, the default config was changed to
  "Use pool instead of server".  This needs a corresponding
  update to /etc/dhcp/dhclient-exit-hooks.d/ntp, since the
  DHCP specified servers now get added to the default pool
  config instead of replacing them.
  
  This affects Xenial only as the Yakkety build includes the upstream fix
  (1:4.2.8p7+dfsg-1).
  
- Original Debian busg https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809344 
+ Original Debian busg https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809344
  & https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806676
+ 
+ [Test Case]
+ 
+ mterry isn't sure on this.  Robie or Philip, do you have simple
+ instructions?
+ 
+ [Regression Potential]
+ 
+ As noted in comments #1 and #2, this SRU might surface an issue if the
+ user is receiving a broken set of NTP servers.
+ 
+ And as noted in comment #4, some people might be hackishly using the
+ distinction between spaces and tabs in the config file to trick our
+ current hook.  Debian has gotten rid of that distinction, so that hack
+ will stop working on distro-upgrade anyway.  The fix is *probably* going
+ to help more people who unintentionally mixed the two up rather than the
+ few that are relying on that bug.  But that bit can be easily dropped
+ from the SRU if ya like.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ntp in Ubuntu.
https://bugs.launchpad.net/bugs/1656801

Title:
  ntp: changing the default config from server to pool broke the dhcp
  hook

Status in ntp package in Ubuntu:
  Fix Released
Status in ntp source package in Xenial:
  Triaged
Status in ntp package in Debian:
  Fix Released

Bug description:
  In 1:4.2.8p3+dfsg-1, the default config was changed to
  "Use pool instead of server".  This needs a corresponding
  update to /etc/dhcp/dhclient-exit-hooks.d/ntp, since the
  DHCP specified servers now get added to the default pool
  config instead of replacing them.

  This affects Xenial only as the Yakkety build includes the upstream
  fix (1:4.2.8p7+dfsg-1).

  Original Debian busg https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809344
  & https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806676

  [Test Case]

  mterry isn't sure on this.  Robie or Philip, do you have simple
  instructions?

  [Regression Potential]

  As noted in comments #1 and #2, this SRU might surface an issue if the
  user is receiving a broken set of NTP servers.

  And as noted in comment #4, some people might be hackishly using the
  distinction between spaces and tabs in the config file to trick our
  current hook.  Debian has gotten rid of that distinction, so that hack
  will stop working on distro-upgrade anyway.  The fix is *probably*
  going to help more people who unintentionally mixed the two up rather
  than the few that are relying on that bug.  But that bit can be easily
  dropped from the SRU if ya like.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/1656801/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to