On 17.10.2017 [08:56:17 -0000], Jan Gutter wrote: > @nacc I built from source to verify that the one-liner is directly > responsible for fixing and breaking the issue (inherent paranoia). I did > test with the binaries and they worked.
Ah ok, yeah -- I guess that's reasonable, and is a good preemptive test, but given that it needs to be backported to a different release, feels a bit like busywork (the same time could have been spent building it for xenial :) > Apologies, I'm unfamiliar with the Ubuntu SRU process as you can > probably see. What exactly is an "MP" and how would one go about to > propose one? MP = Merge Proposal. Roughly like GitHub's Pull Requests (PR), except less formal with Git (bzr I think is somewhat more first-class in Launchpad). > I'm aware of the need of testing bugfixes like these, I'm not familiar > with your release pipeline, however. http://www.justgohome.co.uk/blog/2017/07/developing-ubuntu-using- git.html may help a bit. Roughly: $ sudo snap install --classic git-ubuntu $ git ubuntu clone iproute2 $ cd iproute2 $ ... make and commit changes $ git ubuntu submit Now, the issue is that middle bit, where you have to know a bit about source packaging. That is, simply cherry-picking the upstream/Debian fix is not quite right, as you need to change it into a Quilt patch and then insert a changelog entry. We are currently developing a fix for that so you can just do a $ git ubuntu remote add debian $ git cherry-pick 72b365e83 $ git ubuntu build-source And it should spit out a commit that has the quiltify'd and changelogify'd result that you can use as a base or to submit. Feel free to find me on IRC if you want some more pointers. In the meanwhile, I'll try and look at Monique's debdiffs this week. -Nish -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to iproute2 in Ubuntu. https://bugs.launchpad.net/bugs/1720126 Title: [ip link] Message truncated error for large number of passthrough VFs Status in iproute2 package in Ubuntu: Fix Released Status in iproute2 source package in Trusty: New Status in iproute2 source package in Xenial: Confirmed Status in iproute2 source package in Zesty: Fix Released Status in iproute2 package in CentOS: Unknown Bug description: [Impact] When querying a Physical Function netdev with a large amount of VF's (more than 30), the resulting return message can overflow the 16K netlink message buffer. This can be fixed by enabling message peeking on the socket and resizing the buffer on receive, or by simply enlarging the receive buffer. Since there's an upper limit to the number of VF's per PF, it's relatively sane to just enlarge the receive buffer. Please see the attached patch. [Test Case] # Set up 60 VF's on an SR-IOV device ip link show > /dev/null Observe the following: Message truncated Message truncated Message truncated [Regression Potential] 1) Applications relying on the broken behaviour will need to be updated, but it would be a really dubious use case. 2) Increasing the rx buffer size increases the memory footprint (but realistically, this is tiny). 3) Extra processing time is now needed to parse the larger buffer, in the case that a call to "ip link" is on the critical time path of an application, (called multiple times in a tight loop, for example), it would affect load. [Other Info] Observed on Ubuntu kernel 4.4.0-93-generic on both 14.04 and 16.04 ===================================================================================================== Ubuntu16 system stack@cluster04:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 16.04.3 LTS Release: 16.04 Codename: xenial stack@cluster04:~$ uname -r 4.4.0-93-generic stack@cluster04:~$ apt-cache policy iproute2 iproute2: Installed: 4.3.0-1ubuntu3.16.04.1 Version table: *** 4.3.0-1ubuntu3.16.04.1 500 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages ================================================================================================= Ubuntu14 system: root@boomslang:~# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 14.04.3 LTS Release: 14.04 Codename: trusty root@boomslang:~# uname -r 4.4.0-96-generic root@boomslang:~# apt-cache policy iproute2 iproute2: Installed: 3.12.0-2ubuntu1 Version table: *** 3.12.0-2ubuntu1 0 500 http://za.archive.ubuntu.com/ubuntu/ trusty-updates/main amd64 Packages To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1720126/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
