Gunnar, Running it through "sh -n" is definitively a good way how to test a shell script. It of course will miss a lot of errors (variable typos, failing programs in a set -e script, etc.), but it at least will catch obvious syntax errors. So ignoring faulty scripts and showing some error message (in ~/.xsession-errors or even a dialog) seems appropriate to me.
Thanks for working on this! I'll review the MP now. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to lightdm in Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script Status in Light Display Manager: In Progress Status in “gdm” package in Ubuntu: Triaged Status in “lightdm” package in Ubuntu: In Progress Bug description: Binary package hint: gdm After adding "function AddPath { PATH="$1:$PATH" }" to $HOME/.profile made the Xorg startup fail. (At that moment I had already forgotten the changes made to the .profile). As I had autologin that meant it kept trying to login and finally showed me the graphics reconfiguration screen. That sent me to a huge hunt for xorg conf and setup problems. Anyway finally tracked this down. I had used bash syntax in .profile file whereas it was run with sh. This is not a bug per se but I think a user mistake in ".profile" shouldn't bring the whole xorg startup to a halt as it does with autologin. I propose running user ".profile" and ".xprofile" scripts so that Xsession script continues running even if they have errors. I'm not sure whether this change would have some negative effects as well. 1) Ubuntu Lucid, Linux egon-laptop 2.6.32-25-generic #45-Ubuntu SMP Sat Oct 16 19:48:22 UTC 2010 i686 GNU/Linux 2) gdm 2.30.2.is.2.30.0-0ubuntu4 To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
