Public bug reported:

The Bionic DEP8 tests for iptables are in bad shape[1], even in the
migration-reference/0 run.

There are two types of failures:
a) some commands have an exit status of 1 when called with the -h (for help) 
option, which is what some tests do
b) iptables-compat-save (and its IPv6 counterpart) also exit with status 1, 
even when there are chains/tables to save

I'll propose:
a) grep the help output instead of relying on the exit status
b) call the command with the -d (dump) option. That doesn't exit 0 in the 
success case, and actually dumps data when there are tables to do so


1. https://autopkgtest.ubuntu.com/packages/i/iptables/bionic/amd64

** Affects: iptables (Ubuntu)
     Importance: Undecided
         Status: Fix Released

** Affects: iptables (Ubuntu Bionic)
     Importance: Undecided
     Assignee: Andreas Hasenack (ahasenack)
         Status: In Progress

** Also affects: iptables (Ubuntu Bionic)
   Importance: Undecided
       Status: New

** Changed in: iptables (Ubuntu Bionic)
       Status: New => In Progress

** Changed in: iptables (Ubuntu Bionic)
     Assignee: (unassigned) => Andreas Hasenack (ahasenack)

** Changed in: iptables (Ubuntu)
     Assignee: Andreas Hasenack (ahasenack) => (unassigned)

** Changed in: iptables (Ubuntu)
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to iptables in Ubuntu.
https://bugs.launchpad.net/bugs/2019022

Title:
  Bionic dep8 tests are failing

Status in iptables package in Ubuntu:
  Fix Released
Status in iptables source package in Bionic:
  In Progress

Bug description:
  The Bionic DEP8 tests for iptables are in bad shape[1], even in the
  migration-reference/0 run.

  There are two types of failures:
  a) some commands have an exit status of 1 when called with the -h (for help) 
option, which is what some tests do
  b) iptables-compat-save (and its IPv6 counterpart) also exit with status 1, 
even when there are chains/tables to save

  I'll propose:
  a) grep the help output instead of relying on the exit status
  b) call the command with the -d (dump) option. That doesn't exit 0 in the 
success case, and actually dumps data when there are tables to do so


  1. https://autopkgtest.ubuntu.com/packages/i/iptables/bionic/amd64

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iptables/+bug/2019022/+subscriptions


-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to