Hi all,
Thanks for the bugfixes Avi, please go ahead and commit them! :)
It's unfortunate that there is duplicated effort here, since I'd
already fixed all the same bugs in my local copy. It's my own damn
fault, of course, for not committing them earlier. Sorry about that.
Presently I can't commit because of formatting confusions, which are
being way more complicated than you'd expect. It's not a big deal,
but getting everything merged in properly will take me an hour or so,
which I won't be able to devote to it for another week or two.
As for formatting: all spaces, no tabs is fine with me. I still
think we should standardize on Jindent 2.1's implementation of this,
since that makes it easy to get back to the canonical form when
things get screwy. I propose using the standard Sun-Style.jin with
this exception for the spaces:
emulateTabs = true
I ran all my local code through Jindent as described, expecting it to
come out looking just like the repository version. It turns out,
though, that the repository version has lots of minor glitches
compared to the Jindent version: a couple extra spaces here, a
missing JavaDoc comment there. Thus, committing the Jindent version
will again produce really long diffs-- just the problem I was
complaining about a couple of days ago. I think we should go ahead
and commit the Jindent version anyway, though, since a formatting
change has already happened recently so it won't do much harm if we
do it again soon. Thoughts?
OK, I'm now going out of email range (!?) for a week. Have fun...
I'll merge in my stuff when I get back. :)
-ds
________________________________________________________________________
David Soergel .oooO Oooo. "Music and Living----"
123 Forest View ( ) ( ) "The same thing," said Pooh.
Woodside, CA 94062 \ ( ) / [EMAIL PROTECTED]
(650) 303-5324 \_) (_/ http://www.lorax.org
________________________________________________________________________
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
