Hi all,

I found out that I had a failure on the cat tests, this because diff uses /proc/self/exe which only works if diff is part of toybox which it is not, so I changed this failing test to make use of cmp and while doing that I implemented some of the other tests which were in that test script as 'future work'.

gr
E.

--
Elie De Brauwer

# HG changeset patch
# User Elie De Brauwer <[email protected]>
# Date 1354969720 -3600
# Node ID d02da157a6c4e6831da1349c0cb2fa741475219a
# Parent  dc4a38a1327084fc6041b3462e8dd3bdc4363d4e
Adding tests for cat

diff -r dc4a38a13270 -r d02da157a6c4 scripts/test/cat.test
--- a/scripts/test/cat.test	Fri Dec 07 06:26:21 2012 -0600
+++ b/scripts/test/cat.test	Sat Dec 08 13:28:40 2012 +0100
@@ -4,18 +4,28 @@
 
 #testing "name" "command" "result" "infile" "stdin"
 
+echo "one" > file1
+echo "two" > file2
 testing "cat" "cat && echo yes" "oneyes\n" "" "one"
+testing "cat -" "cat - && echo yes" "oneyes\n" "" "one"
+testing "cat file1 file2" "cat file1 file2" "one\ntwo\n"  "" ""
+testing "cat - file"      "cat - file1"     "zero\none\n" "" "zero\n"
+testing "cat file -"      "cat file1 -"     "one\nzero\n" "" "zero\n"
+
+testing "cat file1 notfound file2" \
+        "cat file1 notfound file2 2>stderr && echo ok ; cat stderr; rm stderr" \
+        "one\ntwo\ncat: notfound: No such file or directory\n" "" ""
+
 testing "cat file1" \
-	"cat /proc/self/exe > file1 && diff -u /proc/self/exe file1 && echo yes" \
-	"yes\n" "" ""
-#testing "cat file1 file2" "cat /bin/cat file1 > file2 && diff -u -
+        "cat /proc/self/exe > file1 && cmp /proc/self/exe file1 && echo yes" \
+        "yes\n" "" ""
 
 testing "cat - file1" \
-	"cat - file1 | diff -a -U 0 - file1 | tail -n 1" \
-	"-hello\n" "" "hello\n"
+        "cat - file1 | diff -a -U 0 - file1 | tail -n 1" \
+        "-hello\n" "" "hello\n"
 
-rm file1
-#testing "cat file1 file2" "cat $0"
-#testing "cat - file"
-#testing "cat > /dev/full"
-#testing "cat file1 notfound file2"
+testing "cat > /dev/full" \
+        "cat - > /dev/full 2>stderr && echo ok; cat stderr; rm stderr" \
+        "cat: xwrite: No space left on device\n" "" "zero\n"
+
+rm file1 file2
\ No newline at end of file
_______________________________________________
Toybox mailing list
[email protected]
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Reply via email to