On 08/24/2013 05:20:06 AM, Felix Janda wrote:
Should have tested the previous two patches more than that they compile.

The changes

-    facstr = dec(LOG_FAC(pri), facilitynames);
+    facstr = dec(pri & LOG_FACMASK, facilitynames);

-    for (tk = "!=*"; tk; tk++, bits <<= 1) {
+    for (tk = "!=*"; *tk; tk++, bits <<= 1) {

fix Pass 3 while

- while (file && !strcmp(file->filename, tokens[1])) file = file->next; + while (file && strcmp(file->filename, tokens[1])) file = file->next;

fixes Pass 4.

If none of these have been applied yet, I could prepare new patches
which don't leave the toy broken in between them.

I like the incremental nature of it, but I'm still not sure why patch 4 _doesn't_ seem to break defconfig. (C is weird about structs it hasn't seen the declaration for yet...)

I need to frown at it a bit more...

Rob
_______________________________________________
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Reply via email to