On Wed, Sep 11, 2013 at 5:30 AM, Felix Janda <[email protected]> wrote:
> Ashwini Sharma wrote: > > On Sat, Sep 7, 2013 at 11:47 PM, Isaac <[email protected]> wrote: > > > > > On Mon, Sep 02, 2013 at 11:15:14AM +0900, Ashwini Sharma wrote: > > > > HI Rob & list, > > > > > > > > Attached is the patch for _route_ command. It does display, add > and del > > > > functions for routing tables. > > > > Have a look at it. > > > > > > > > regards, > > > > Ashwini Kumar > > > > > > OK, I took a quick look through it. > > > First, thanks for doing route. > > > > > > I note that show_route_help is identical to show_help() apart from the > > > error message. That's probably not needed. > > > > > > > Didn't use show_help(), as this doesn't exit whereas an exit is intended > > for route. > > may be show_help() can be updated to do that. > > For this there is toys.exithelp. Set it to one and then call error_exit(). > Yup, show_route_help, already does that. It was to be called many times, hence made a function show_route_help(). > > Felix >
_______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
