When useradd started using xfork(), the conditional in 
else if (pid > 0)
became unnecessary, since else means pid is nonzero and xfork makes it
non-negative.
However, the "if" was not deleted.

--
Thanks,
Isaac Dunham
diff --git a/toys/pending/useradd.c b/toys/pending/useradd.c
index 99e2530..0a79064 100644
--- a/toys/pending/useradd.c
+++ b/toys/pending/useradd.c
@@ -61,7 +61,7 @@ static int exec_wait(char **args)
   pid_t pid = xfork();
 
   if (!pid) xexec(args);
-  else if waitpid(pid, &status, 0);
+  else waitpid(pid, &status, 0);
 
   return WIFEXITED(status) ? WEXITSTATUS(status) : WTERMSIG(status)+127;
 }
_______________________________________________
Toybox mailing list
[email protected]
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Reply via email to