new patch attached. On Wed, Nov 18, 2015 at 9:34 PM, Rob Landley <[email protected]> wrote: > On 11/18/2015 10:26 AM, enh wrote: >> On Tue, Nov 17, 2015 at 7:00 AM, Rob Landley <[email protected]> wrote: >>> On 11/16/2015 02:12 AM, José Bollo wrote: >>>> AFAIK !!! == ! >>> >>> Yes it does. >>> >>> I've got it batched in with the design issue (traversing symlinks needs >>> the fd not the symlink length), but I'm in San Diego at present. (And >>> then Santa Clara the second half of the week...) >> >> the more you batch stuff, the more you incentivize me to not report >> other bugs until everything else is in. "half an eye is better than no >> eye". > > What I mean is "I have pending changes to find, and would have to back > them out and apply this and re-patch them, which is just awkward enough > I keep meaning to sit down and fix the rest of the find stuff and commit > this in with that, except this week's been crazy". > >> the find fixes are more urgent though. can we get those in? (the >> brillo folks use find to collect the tests to run, so they want me to >> commit that locally otherwise. actually, they wanted it monday but >> i've been ooo.) > > I just got to my room in Santa... Clara? and am exhausted, but I'll see > if I can rally. If not, should be doable in the morning. > > Sorry for the delay... > >>> Rob > > Rob > > (Everything in california is named "san" and I can't tell them apart. I > keep failing my san rolls. The ticket for san diego was just named > "san", the airport for santa clara is called san jose, and I almost > booked a room in san francisco by mistake but that's an hour away. I > _think_ the last cith was in california, anyway. It rained on me at some > length the first night, which I'm told would disqualify it from being > california...)
-- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer.
From 583180e128075448024809ef8c0e0f001c1e6692 Mon Sep 17 00:00:00 2001 From: Elliott Hughes <[email protected]> Date: Sun, 20 Dec 2015 10:06:59 -0800 Subject: [PATCH] Fix ls -Z with symlinks. The sense of -L was flipped. --- toys/posix/ls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toys/posix/ls.c b/toys/posix/ls.c index 7dc85ac..709b360 100644 --- a/toys/posix/ls.c +++ b/toys/posix/ls.c @@ -192,7 +192,7 @@ static int filter(struct dirtree *new) // fchmodat(), mknodat(), readlinkat() so we could do this without // even O_PATH? But no, this is 1990's tech.) int fd = openat(dirtree_parentfd(new), new->name, - O_PATH|(O_NOFOLLOW*!!(toys.optflags&FLAG_L))); + O_PATH|(O_NOFOLLOW*!(toys.optflags&FLAG_L))); if (fd != -1) { if (-1 == lsm_fget_context(fd, (char **)&new->extra) && errno == EBADF) -- 2.6.0.rc2.230.g3dd15c0
_______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
