On Sat, Mar 19, 2016 at 7:56 AM, Rob Landley <[email protected]> wrote: > > > On 03/18/2016 10:31 PM, enh wrote: >> On Fri, Mar 4, 2016 at 2:28 PM, Rob Landley <[email protected]> wrote: > ... >>> My pending cleanup of lsof needs to address the fact it takes 18 seconds >>> to produce its first line of output when run with no arguments on my >>> netbook (the ubuntu version takes 0.7). That's a largeish thing. >> >> do you know why? for me on my desktop, toybox lsof is 10x faster than >> the GNU one (2s vs 18s). (that's time to complete. but the initial >> pause is longer for the GNU one too.) > > Not yet. Haven't cycled back around to that todo item yet.
i had a look, and most of the time taken by our lsof goes into checking the /proc/net files over and over. i'll send out a patch adding a cache that makes lsof 10x faster. (that is, for me our lsof is now 100x faster than the traditional one, 0.19s instead of 18s.) >>>> Also, did you say a few months back that you'd started on 'ioctl'? If >>>> so, do you want to check that in? If not, correct my misapprehension >>>> and I'll do it at some point. (For that and prctl I'm also slowed >>>> down by the fact that there's much to dislike about the existing >>>> commands...) >>> >>> Oh right, that. I should go do that. >> >> ping. others can't start fixing it until something's checked in. >> >> (i think it's fine to have a directory even more broken than pending/ >> if that makes you more comfortable.) > > toys/pending/sh.c doesn't resolve environment variables, or handle pipes > or & > > toys/pending/mke2fs.c only makes a superblock, and does it wrong. (I > have the infrastructure to do that right now, just haven't gotten back > to it. I've been looking at fat instead.) > > toys/pending/ping.c I got distracted from finishing _five_times_ and I > don't think it currently does anything if you run it. (I had other > versions contributed but very much wanted to get ipv4 and ipv6 in the > same binary, and base it on https://lwn.net/Articles/420799/ instead of > stuff requiring root access, and it doesn't take that much to implement...) > > Seriously, pending has a lot of broken. it varies wildly though, from "barely started" to "almost done". > But yeah, I should do ioctl this weekend. > >>> Rob > > Still Rob -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. _______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
