On Tue, May 10, 2016 at 1:13 AM, Rob Landley <[email protected]> wrote: > > > On 05/10/2016 12:28 AM, enh wrote: >> On Mon, May 9, 2016 at 8:45 PM, Rob Landley <[email protected]> wrote: >>> On 05/09/2016 04:43 PM, Evgenii Stepanov wrote: >>>> Now, if we want to really preserve this check logic under safestack, >>>> we will have to do something safestack-specific. There is no way to >>>> keep pretending that there is a single, continuous stack region and >>>> still get realistic results. >>> >>> If you can hide it in lib/platform.h and lib/platform.c, go for it. >> >> (well, we don't need this... the "don't do the arithmetic if you're >> NORECURSE" patch https://android-review.googlesource.com/#/c/223875/ >> is better for us.) > > Let's see... > > https://android-review.googlesource.com/#/c/223875/ > > becomes > > git fetch https://android.googlesource.com/platform/external/toybox \ > refs/changes/60/223875/1 && git cherry-pick FETCH_HEAD > > Except... what does the 60 mean? > > fatal: Couldn't find remote ref refs/changes/60/223875/1
i get git fetch https://android.googlesource.com/platform/external/toybox refs/changes/75/223875/1 && git cherry-pick FETCH_HEAD instead. in fact, playing around with a small random sample it looks like those two digit are always the last two digits of the CL number for me. so i've no idea where your /60/ came from! > Rob -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. _______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
