On Sun, 29 May 2016 22:33:32 -0500 Rob Landley <[email protected]> wrote:
> Browsing through the cyanogenmod repository. Since they never > submitted patches to me I'm not going to copy their stuff verbatim > (technically it could be under a different license), but I'd like to > address their issues in mainline (modulo the pending stuff), and I > get to this: > > http://review.cyanogenmod.org/#/c/131295/ > > commit b90823e298988ff365cdf8e6d7c17687c3897d55 > Author: Scott Mertz <[email protected]> > Date: Tue Feb 2 14:40:31 2016 -0800 > > Don't exit with failure code when cp ownership preservation fails > > POSIX spec states that it is unspecified whether '-p' prints > errors to stderr when preserving ownership fails. GNU coreutils > implementation does not write anything to stderr when this fails. > Additionally, '-a' is only specified in GNU coreutils & specifies > nothing is to be written to stderr in the case of failure. Switch the > implementation to align with GNU coreutils while still satisfying > POSIX. > > OPO-358 > Change-Id: Ibb7c94fbf553a178b3f88a724ef6f737275a4205 > > I tried to pull up the OPO-358 thing to see what the original bug > report was, but it requires a login to view it: > > https://jira.cyngn.com/browse/OPO-358 > > So I tested it myself, and they're _wrong_: > > dd if=/dev/zero of=vfat.img bs=1M count=1 > mkfs.vfat vfat.img > mkdir vfat > sudo /bin/bash > toybox mount vfat.img vfat > > And then when I go: > > # cp -a todo vfat/ > cp: failed to preserve ownership for ‘vfat/todo/attachment.bin.4’: > Operation not permitted cp: failed to preserve ownership for > ‘vfat/todo/attachment-0002.bin’: Operation not permitted cp: failed > to preserve ownership for ‘vfat/todo/netstat.patch’: Operation not > permitted cp: failed to preserve ownership for > ‘vfat/todo/githash.patch’: Operation not permitted cp: failed to > preserve ownership for ‘vfat/todo/expr.patch’: Operation not > permitted ... > > The stock ubuntu 14.04 vesion is giving warnings about > inability to preserve ownership...? Is that like throwing an error when trying to delete a non existent file? The end result is what you want, it's only complaining coz it can't do that, not that what you want done is already done. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world.
signature.asc
Description: PGP signature
_______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
