On Thu, Oct 18, 2018, 10:51 Rob Landley <r...@landley.net> wrote: > On 10/17/2018 06:24 PM, enh wrote: > > $ ./toybox su --help > > toybox: Not root (see "toybox --help") > > > > not sure what the fix is there though. > > Hmmm, I think it's that TOYFLAG_NEEDROOT should be checking geteuid() not > getuid(), but that's a security thing and I want to go over all the users > thoroughly before making the change. >
Isn't the problem that we should handle --help before checking whether the caller is root? The todo list for this release is now: > > Finish/promote watch > fix crunch_str(): utf8 combining chars are trailing, not leading > promote gzip (decompression side, using lib/deflate.c) > Finish 79c403179b603a9f 482c422f8e8ec51 009b55edc4bad5b4 8993496e496cdbc > getconf: -a, build on musl (missing symbol?) > find -empty > NDK dynamic build (__android_log_write redef) > su - root says "not root" > TOYFLAG_NEEDROOT should check geteuid() not getuid()? Audit everybody. > > Rob >
_______________________________________________ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net
