any thoughts on this? without this i can't update AOSP past https://github.com/landley/toybox/commit/82a33b3f060e163b14155e8f6833ec30514a609b because that breaks testing infrastructure that uses pidof.
(i should perhaps have resisted the bootchartd cleanup that makes this patch seem bigger than it really is, but that caller of names_to_pid was a real head-scratcher.) On Thu, Jul 11, 2019 at 2:03 PM enh <[email protected]> wrote: > > Before this patch, we're effectively doing `pidof -x` all the time. This > patch changes names_to_pid() to allow us to say whether or not we want to > include scripts, and adjusts the callers appropriately. > > Also add tests for `pidof` versus `pidof -x` which pass after this > patch, without regressing the existing killall tests. > --- > lib/lib.c | 21 ++++++++++++--------- > lib/lib.h | 3 ++- > tests/pidof.test | 33 +++++++++++++++++++++++++++++++++ > toys/lsb/killall.c | 2 +- > toys/lsb/pidof.c | 5 +++-- > toys/pending/bootchartd.c | 38 ++++++++++++-------------------------- > 6 files changed, 63 insertions(+), 39 deletions(-) > create mode 100644 tests/pidof.test _______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
