Hi,

noticed a couple of makefile issues.

First looks like a typo to me.

Second fixes "make -j".

I also think "make silentoldconfig" might be broken in some way as I
ran out of patience after waiting a few minutes for it to complete.

Kind regards,

Patrick
From 1032320464fbcc9f2154715cb28e7198639a5401 Mon Sep 17 00:00:00 2001
From: Patrick Oppenlander <[email protected]>
Date: Fri, 2 Aug 2019 16:35:43 +1000
Subject: [PATCH 2/2] fix parallel make build failure

make: *** No rule to make target 'generated/Config.probed', needed by 'Config.in'.  Stop.
make: *** Waiting for unfinished jobs....
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 1bd3b25a..397e4777 100644
--- a/Makefile
+++ b/Makefile
@@ -31,6 +31,7 @@ $(KCONFIG_CONFIG): $(KCONFIG_TOP)
 	exit 1; fi
 
 $(KCONFIG_TOP): generated/Config.in generated/Config.probed
+generated/Config.probed: generated/Config.in
 generated/Config.in: toys/*/*.c scripts/genconfig.sh
 	scripts/genconfig.sh
 
-- 
2.22.0

From 35ec18da06b02588a1214fa2a4de301c05b5c9e9 Mon Sep 17 00:00:00 2001
From: Patrick Oppenlander <[email protected]>
Date: Fri, 2 Aug 2019 16:35:16 +1000
Subject: [PATCH 1/2] fix typo in Makefile

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 1c1c4a4c..1bd3b25a 100644
--- a/Makefile
+++ b/Makefile
@@ -26,7 +26,7 @@ include kconfig/Makefile
 -include .singlemake
 
 $(KCONFIG_CONFIG): $(KCONFIG_TOP)
-	@if [ -e "$(KCONFG_CONFIG)" ]; then make silentoldconfig; \
+	@if [ -e "$(KCONFIG_CONFIG)" ]; then make silentoldconfig; \
 	else echo "Not configured (run 'make defconfig' or 'make menuconfig')";\
 	exit 1; fi
 
-- 
2.22.0

_______________________________________________
Toybox mailing list
[email protected]
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Reply via email to