On Fri, Nov 22, 2019 at 4:53 AM Rob Landley <[email protected]> wrote:
>
> On 11/21/19 4:13 PM, enh via Toybox wrote:
> > Includes new tests.
> > ---
> >  lib/portability.h     |   3 ++
>
> Applied, by why add this #include to portability.h when it's not in an #ifdef?
> The main #includes are in toys.h.

i was going to put it in toys.h initially, but it seemed (from the
comments on each block) like toys.h was only meant for _standard_
headers?  <getopt.h> is a non-standard (but common to BSD, glibc,
bionic, macOS) header that defines the non-standard *long* getopt
functions. the POSIX getopt() function is in <unistd.h>.

if you add a "non-standard but everyone has them" block to toys.h i'll
put any similar future cases there :-)

> Rob
> _______________________________________________
> Toybox mailing list
> [email protected]
> http://lists.landley.net/listinfo.cgi/toybox-landley.net
_______________________________________________
Toybox mailing list
[email protected]
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Reply via email to