On Mon, Aug 3, 2020 at 3:52 AM Rob Landley <r...@landley.net> wrote:
>
> On 7/31/20 4:19 PM, Mark Salyzyn via Toybox wrote:
> > On 7/31/20 12:30 PM, Mark Salyzyn wrote:
> >> -P flag was fake just to provide compatibility. Add support for -P
> >> maximum process count to actually create parallelism. Does not
> >> support SIGUSR1 or SIGUSR2 increment/decrement signals as publicly
> >> documented for other variants. If max-proc is 0, run as many
> >> processes as possible simultaneously.
> >>
> > The Bug: referenced were scrubbed, and regardless hides some history. When
> > using
> > toybox xargs for a kernel build, it added 5 minutes to the total build time
> > when
> > it ignored the -P8 flag and exec'd only one at a time.
> >
> > Sincerely -- Mark Salyzyn
>
> I did a slightly smaller implementation (I'd looked at implementing -P before,
> but waited for somebody to complain about its absence), which supports SIGUSR1
> and SIGUSR2.
>
> Does what I checked in work for you?
it passes the tests on Android (i synced AOSP this morning), but i'll
let salyzyn report specifically on the kernel build times.
(i've attached a patch to fix the -P help text alignment.)
> Thanks,
>
> Rob
> _______________________________________________
> Toybox mailing list
> Toybox@lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net
From e41fa1f1ba9c04d92a5339a8c0fc6343cc5db94e Mon Sep 17 00:00:00 2001
From: Elliott Hughes <e...@google.com>
Date: Mon, 3 Aug 2020 12:08:10 -0700
Subject: [PATCH] xargs: fix help formatting.
---
toys/posix/xargs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toys/posix/xargs.c b/toys/posix/xargs.c
index 26c1b250..cc3ee3de 100644
--- a/toys/posix/xargs.c
+++ b/toys/posix/xargs.c
@@ -26,7 +26,7 @@ config XARGS
-n Max number of arguments per command
-o Open tty for COMMAND's stdin (default /dev/null)
-p Prompt for y/n from tty before running each command
- -P Parallel processes (default 1)
+ -P Parallel processes (default 1)
-r Don't run with empty input (otherwise always run command once)
-s Size in bytes per command line
-t Trace, print command line to stderr
--
2.28.0.163.g6104cc2f0b6-goog
_______________________________________________
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net
