mksh doesn't support the {a..b} bashism or the ${!name} bashism, causing
the tests to fail on Android.This works for me on both mksh and bash (both tested on Debian). --- tests/chmod.test | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
From 1c4fcd9161c6cdbbd5a9d300fba2fd69ae97d260 Mon Sep 17 00:00:00 2001 From: Elliott Hughes <[email protected]> Date: Thu, 7 Jan 2021 15:24:35 -0800 Subject: [PATCH] chmod.test: fix the tests to work on mksh as well as bash. mksh doesn't support the {a..b} bashism or the ${!name} bashism, causing the tests to fail on Android. This works for me on both mksh and bash (both tested on Debian). --- tests/chmod.test | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/chmod.test b/tests/chmod.test index 9adca60f..cd4f8100 100755 --- a/tests/chmod.test +++ b/tests/chmod.test @@ -24,16 +24,20 @@ mkdir dir touch file # We don't need to test all 512 permissions -file=- dir=d DOfile=touch DOdir=mkdir -unset touch mkdir d -for U in {0..7}; do for G in 0 3 6; do for O in 0 7; do for T in dir file; do +for U in $(seq 0 7); do for G in 0 3 6; do for O in 0 7; do for T in dir file; do chmod 777 $T 2>/dev/null - X=DO$T - rm -rf $T && ${!X} $T + rm -rf $T + if [ "$T" == file ]; then + touch file + C=- + else + mkdir dir + C=d + fi testing "$U$G$O $T" "chmod $U$G$O $T && ls -ld $T | cut -d' ' -f 1" \ - "${!T}$(num2perm $U$G$O)\n" "" "" + "${C}$(num2perm $U$G$O)\n" "" "" done; done; done; done -unset U G O T X +unset U G O T C rm -rf dir file && mkdir dir && touch file 640 testing "750 dir 640 file" "chmod 750 dir 640 file && -- 2.29.2.729.g45daf8777d-goog
_______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
