On 3/2/21 8:13 am, [email protected] wrote:
Message: 5
Date: Tue, 2 Feb 2021 14:49:06 +0800
From: Yi-yo Chiang <[email protected]>
To: Rob Landley <[email protected]>
Cc: [email protected]
Subject: Re: [Toybox] [PATCH 1/2] rm: Check file existence with
lstat() explicitly if "-f" is specified
Message-ID:
<cae6c_vy6ih6oaucwhtwu7uibqwnse1r2_jcik6vtbop+ejz...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
I found the original commit that adds this:
https://android.googlesource.com/platform/bionic/+/35778253a5ed71e87a608ca590b63729d9f88567
There is even a link to this mailing list...
Can't say I completely follow the discussion, as the thread is long and
dated, and I may be missing a lot of context, but I think the rationale is
roughly "faccessat() AT_SYM_NOFOLLOW is not properly supported by some libc
impls, so let's not use it for now". Does this argument still hold though?
I'm not sure how many there are, but I know of at least one linux
version, Nenuzhnix,**that makes use of toybox and doesn't use libc at
all, so the existing methodology needs to be maintained if possible. And
I might add, listed in it's build requirements is not to use any gnu
packages. I won't say it's a mainstream release by any means, but it's
slowly expending and expanding, and becoming interesting.
On Tue, Feb 2, 2021, 12:06 Rob Landley <[email protected]> wrote:
On 2/1/21 9:53 PM, Yi-yo Chiang wrote:
There has to be a reason, but I'll defer that question to Elliott..
https://cs.android.com/android/platform/superproject/+/master:bionic/libc/bionic/faccessat.cpp;l=46;drc=50080a29f7327fcd009344844bb9e643b2d6b9c3
This line also left me scratching my head for half a day.
At a guess, that first explanatory URL in the comment should be:
https://www.openwall.com/lists/musl/2015/02/05/2
Rob
scsijon
_______________________________________________
Toybox mailing list
[email protected]
http://lists.landley.net/listinfo.cgi/toybox-landley.net
