On 2/1/21 6:55 AM, Yi-yo Chiang via Toybox wrote: > Use "" instead of '' to quote commands as the command contains expandable > variables. > > I also found that most of the test cases are not working as intended. > Most of the test commands are like "mount ... >/dev/null 2>&1 && <do > something> > && umount", so there is no visible output when mount succeeds or fails, and > the > "testing" macro doesn't check return code, so the testcases always passes no > matter what. These test cases should be strengthened, thoughts?
Way back when people were asking me how they could help, and the pending directory was already overflowing with stuff for me to review, so I pointed them at the test suite. Unfortunately, the resulting external test contributions generally needed the same kind of review and cleanup that the commands in pending did, but I didn't have a tests/pending. I eventually hijacked the executable bit to indicate which tests should run as part of "make tests" and which ones that should skip, but a single bit of info doesn't capture "expected to fail", "works but doesn't really mean anything", "the tests that are there are ok but it's nowhere near full coverage", and "complete test". Alas, another symptom of toybox not being my day job... Rob _______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
