On Mon, Aug 30, 2021 at 12:39 PM Rob Landley <[email protected]> wrote:
> On 8/30/21 10:56 AM, enh via Toybox wrote: > > Found in github CI by the existing patch tests: > > ``` > > patch: xsignal 0: Invalid argument > > ``` > > Yeah, I bumped into that right after I pushed your commit (it broke the > mkroot > linux kernel build) but got distracted trying to integrate > scripts/record-commands into mkroot.sh instead of immediately fixing it. > > > When I grepped for places that would be affected by my `kill -0` change, > > I grepped toys/, not lib/. (And I only ran the tests for the toys I > > touched, not all the tests, and CI was already broken so we didn't > > notice the new breakage until the old breakage was fixed :-( ) > > Your commit changed list_signals() to start from 1 but didn't do the same > for > xsignal_all_killers(). One character fix. yeah, i sent you a more complicated fix in case someone was tempted to reorder the array (note that in list_signals() the loop variable is the signal number, but in xsignal_all_killers() the loop variable is the array index), but (a) your smaller fix works and (b) we know we have a test that will catch this if someone does break it, so lgtm :-) thanks! (and sorry for not running all the tests! it's _just_ slow enough on my laptop to run them all that i tend to only run the specific toy's tests.) > Pushed now, sorry for the delay. (I've > been mostly AFK this week.) > no worries --- me too, and likely to be worse for the next few weeks thanks to perf season starting! i'll get AOSP back in sync with you as soon as i can so we don't drift any further behind... > Rob >
_______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
