On 12/2/22 11:20, Vincent Donnefort via Toybox wrote:
> Currently, /proc/modules is a strong requirement for loading modules.
> This is problematic as procfs might not always be available. Checking
> /proc/modules only allows to flag if a module is already present to
> avoid loading it. It's something the kernel handles well already
> (finit_module returns EEXIST). So if this might be good to have, not
> being able to check the module presence shouldn't prevent modprobe from
> trying.

Applied, but you're right it should probably just try to load it and let the
failure happen instead of having two codepaths. (I've added a TODO to my copy
for the cleanup pass.)

Thanks,

Rob
_______________________________________________
Toybox mailing list
[email protected]
http://lists.landley.net/listinfo.cgi/toybox-landley.net

Reply via email to