On Thu, Nov 2, 2023 at 12:06 PM Rob Landley <[email protected]> wrote: > > On 11/1/23 18:45, enh wrote: > > do you want a patch with the arm32 flags too? > > Yes please.
(sent.) > I applied your patch and then moved stuff to elf.c and tidied it a > little. Could you confirm the riscv flags still print right with the new > trick? yeah, lgtm. (though the arm32 patch fixes the arithmetic in file.c so it works for 32-bit ELF files as well as 64-bit files, so now it'll work for riscv32 too.) > I haven't got a test binary here. (I should break down and add a riscv cross > compiler to the heap and add stripped musl hello world binaries for each > architecture to tests/files...) yeah, i almost sent you one but i then started to wonder about which specific variants we should have and so on. i'll send you something when i send you the readelf attributes support. (but let me know if you just want a riscv64 ELF file _now_ and corresponding file(1) test to improve coverage.) > Rob _______________________________________________ Toybox mailing list [email protected] http://lists.landley.net/listinfo.cgi/toybox-landley.net
