(see debugging on http://github.com/landley/toybox/issues/512.)
On Thu, Jul 18, 2024 at 5:53 PM Rob Landley <r...@landley.net> wrote: > > On 7/17/24 07:56, enh wrote: > >> > FAIL: tar honor umask > >> > echo -ne '' | umask 0022 && rm -rf dir && mkdir dir && tar xf > >> > $FILES/tar/dir.tar && stat -c%A dir dir/file > >> > --- expected 2024-07-15 16:20:47.217287424 +0000 > >> > +++ actual 2024-07-15 16:20:47.257287423 +0000 > >> > @@ -1,2 +1,2 @@ > >> > -drwxr-xr-x > >> > --rwxr-xr-x > >> > +drwxrwxrwx > >> > +-rwxrwxrwx > >> > >> I can't reproduce it. I just did a fresh clone on the old machine and "make > >> clean defconfig tests" completed, including running the new tar tests. > >> > >> The _symptom_ is that it ran the new tests against old toybox tar from > >> before > >> commit 93718452b9f6. That's the behavior from before the fix. Is your test > >> setup > >> calling an older toybox tar out of the host $PATH maybe? > > > > no, this was on a device, so it'll be the /system/bin/toybox from the build. > ... > > yeah, that seems to be a mksh compatibility issue. > > I suspect the other issue might also be also mksh, or your slightly different > test setup. It could be that the shell umask command isn't setting umask > properly, or maybe something's violating the assumption that the test command > line is in a new process so state changes a test makes to umask, cd, or > environment variables don't persist in the parent context... > > I'll see if I can reproduce a mksh run of the test here. > > Rob _______________________________________________ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net
