On Thu, Sep 12, 2024 at 11:35 PM Rob Landley <r...@landley.net> wrote:
> On 9/10/24 17:16, enh via Toybox wrote: > > cp -i was showing the _source_ rather than the destination, while -v > > was only showing the source rather than the source _and_ the destination. > > In theory flags is separate because it gets locally modified, oops, i didn't spot that ... i thought it was one of those "multiple toys in the same file with almost-but-not-quite-the-same flags" cases. but since there was already a FLAG() in the same function, i just assumed it was okay in this context. > but at this point > it's only doing that for FLAG_r so you're right all the other tests can > just use > the FLAG() macros. In fact having a separate extra r flag is probably the > correct thing to do here. (I think there were more local flag modifications > before, but they got cleaned up at some point...) > > Applied, I'll try to do a follow-up patch this evening... > thanks! > Rob >
_______________________________________________ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net
