Tim Ansell pisze:

>> I thought that creating all frame classes by
>> hand is boring and all, especially when there seems to be a formal
>> definition of the frames' structure in documents package, so I thought that
>> I'd use the protocol.xml file (actually protocol3.xml for now).
> 
> The idea is that these files should be usable by various libraries to
> dynamically create the packet definitions.

Exactly what I want :)

>> Actually I already started writing a source file generator, and it turns out
>> that this file would be very useful... if it got cleared up a bit. It
>> doesn't validate against the DTD and the property names are missing or
>> misplaced with long names...
> 
> It should probably validate against the DTD :)

Yup... Two more easy targets attached.

The remaining offenders are of two kinds, and are located in the lower
(later?) parts of the documents.

* <string type="formatted"> - type attribute is not defined by the DTD,
should it be formalised? I can see that there is a concept of "formatted
string", but I'm not sure if it has any relevance to the libraries...

* Missing <name> and/or <longname> of properties and/or misplaced <name> and
<longname>; sometimes <name>, <longname> and <description> are exactly the
same - fortunately this is not that common and probably requires sometime
familiar with the protocol to fix that :) [is protocol3.php enough for that?]

>> So the question is: is this file an official definition of the protocol? And
>> if so, could it be made usable? :)
> 
> It will eventually be the "official definition" of the protocol from
> tp04 and onwards. A document similar to protocol3.php will be generated
> from the protocol.xml file (you can see the start of it here -> 
> http://www.thousandparsec.net/tp/dev/documents/protocolxml.php ).

Hmm, is there any XSL or something like that to do that?... ;)

> The protocol3.php document on the website is the official information
> about tp03. However, it would still be really handy for the tp03 file to
> be correct :)

Absolutely... I'm not gonna proceed with libtpproto-java wothout that ;)
-KS


----------------------------------------------------------------------
Najseksowniejsi chlopcy, najladniejsze dziewczyny, sprawdz i ocen

>>>http://link.interia.pl/f1b42
From e75cdd4136dbdba1bdbecae7050be8df60ee92a4 Mon Sep 17 00:00:00 2001
From: Krzysztof Sobolewski <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 20:16:47 +0200
Subject: [PATCH] Typo: descstrut -> descstruct

---
 protocol/protocol.xml |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/protocol/protocol.xml b/protocol/protocol.xml
index 5363235..c550802 100644
--- a/protocol/protocol.xml
+++ b/protocol/protocol.xml
@@ -537,9 +537,9 @@
 		<parameter name="objectParamInteger" type="8">
 			<longname>Integer</longname>
 			<description>An Integer, informational.</description>
-			<descstrut>
+			<descstruct>
 				<structure />
-			</descstrut>
+			</descstruct>
 			<usestruct>
 				<structure>
 					<integer type="unsigned" size="32">
-- 
1.5.2.4

From e00c56f58303ecf8032b2556ad8bdeeae04f91fe Mon Sep 17 00:00:00 2001
From: Krzysztof Sobolewski <[EMAIL PROTECTED]>
Date: Fri, 24 Aug 2007 20:19:33 +0200
Subject: [PATCH] Convert angle brackets to XML entities in a frame's description

---
 protocol/protocol.xml  |    2 +-
 protocol/protocol3.xml |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/protocol/protocol.xml b/protocol/protocol.xml
index c550802..81b17cb 100644
--- a/protocol/protocol.xml
+++ b/protocol/protocol.xml
@@ -1626,7 +1626,7 @@
 	</structure>
 
 	<note>
-			<b>Note:</b>The last modified time should be updated every time a message on the board
+			&lt;b&gt;Note:&lt;/b&gt; The last modified time should be updated every time a message on the board
 			has changed.
 	</note>
 </packet>
diff --git a/protocol/protocol3.xml b/protocol/protocol3.xml
index ac178bc..759ad9e 100644
--- a/protocol/protocol3.xml
+++ b/protocol/protocol3.xml
@@ -1067,7 +1067,7 @@
 	</structure>
 
 	<note>
-			<b>Note:</b>The last modified time should be updated every time a message on the board
+			&lt;b&gt;Note:&lt;/b&gt; The last modified time should be updated every time a message on the board
 			has changed.
 	</note>
 </packet>
-- 
1.5.2.4

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
tp-devel mailing list
[email protected]
http://www.thousandparsec.net/tp/mailman.php/listinfo/tp-devel

Reply via email to