On Tue, 06 Nov 2007, Brett Nash wrote: > [Resend to correct list from correct address] > > On Mon, 2007-11-05 at 23:37 +1300, Lee Begg wrote: > > Closes bug 1825830. Thanks for the bug nash. > > --- > > tpserver/playerconnection.cpp | 18 ++++++++++++++++-- > > 1 files changed, 16 insertions(+), 2 deletions(-) > > + if(!recvframe->isEnoughRemaining(5)) > + throw std::exception(); > + password = recvframe->unpackStdString(); > > Should that be: > ->isEnoughRemaining(4)? > > Wouldn't an empty password be valid?
Just looking down the code a little further there is a test that password is more than 0 chars long, so the password must have at least one character. Later Lee
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ tp-devel mailing list [email protected] http://www.thousandparsec.net/tp/mailman.php/listinfo/tp-devel
