Friday 29 of August 2008 15:45:19 Vincent Verhoeven napisaƂ(a):

> So let's go one layer deeper and just use star systems instead. :)
> Since these are displayed in tpclient-pywx (in contrast with
> galaxies), it can perhaps be assumed that developers will place them
> at the right positions, and thus that you can use them to determine
> map bounds. I think this is the same thing tpclient-pywx uses.
> 
> I attached a patch for this, however you should review it and probably
> design something that is a bit better, because this replaces one
> ad-hoc method with another. Also I only tested this with the Risk
> ruleset, it might break other rulesets.

It looks good as it is. Modulo whitespace, only ;) I applied it and commited to 
trunk, thanks!
[I trust that it really works as I haven't tested it myself ;)]
[Oh, and I just notices the commit message says it fixed NPE, not DBZ... Dang, 
I should have had some sleep first...]

> The current status is that it now manages to draw the maps. Only
> problem is that those are useless because they lack pretty colors. :)
> It's probably because of the peculiarities of the ruleset: it doesn't
> use ships and I think planet ownership is different or something.

Support for ships is optional anyway (and there are some big questions about 
it). Ownership is interesting... Does the sidebar contain player names? And 
most important: are the stars visible? [I should have asked that before 
committing ;)]

> Also, strength is measured by resources because of the absence of
> ships.

Well, in TPModel it's still a fixed number assigned to each colonized planet :)

> Would it be possible to create a configuration that draws 
> useful maps of the Risk ruleset?

I hope so :) But Starmapper does not differentiate between rulesets (yet?) so a 
config file for Risk would look just like for others.
-- 
Ecce Jezuch
"Peace sells -
But who's buying?" - D. Mustaine

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
tp-devel mailing list
[email protected]
http://www.thousandparsec.net/tp/mailman.php/listinfo/tp-devel

Reply via email to