Hi Jarkko,
I think there is a bug in the current version of this patch.
tpm1_pcr_read returns TPM status code (>= 0)
In tpm_do_selftest, after tpm1_pcr_read, rc is compared with
TPM_HEADER_SIZE.
In short:
"if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) {" is never
reached because TPM_ERR_DISABLED(0x7) and TPM_ERR_DEACTIVATED(0x6) are <
TPM_HEADER size.
TPM_HEADER_SIZE beeing already checked in tpm_transmit_cmd, i think a
reasonable fix will be to remove:
if (rc < TPM_HEADER_SIZE)
return -EFAULT;
in tpm_do_self_test.
Can you merge this fix into the current patch or do you want me to send it
to you ?
Best Regards
Christophe
2016-04-05 11:42 GMT+02:00 Jarkko Sakkinen <[email protected]>
:
> On Fri, Apr 01, 2016 at 09:16:15PM -0600, Jason Gunthorpe wrote:
> > On Thu, Mar 31, 2016 at 09:37:56AM +0300, Jarkko Sakkinen wrote:
> > > On Wed, Mar 30, 2016 at 11:46:23PM -0600, Jason Gunthorpe wrote:
> > > > On Wed, Mar 30, 2016 at 04:20:45PM +0300, Jarkko Sakkinen wrote:
> > > >
> > > > > - rc = be32_to_cpu(cmd.header.out.return_code);
> > > > > if (rc == TPM_ERR_DISABLED || rc ==
> TPM_ERR_DEACTIVATED) {
> > > >
> > > > This line is the entire reason it is open coded, I see it being
> > > > removed, but I don't see how the functionality is maintained?
> > >
> > > When tpm_trance_cmd() returns a positive number it is the TPM error
> code
> > > that it returns. tpm_pcr_read() does pass through whatever
> > > tpm_trace_cmd() returns so the above condition should still work as
> > > expected.
> >
> > Okay, everything looks fine to me
>
> I applied this to http://git.infradead.org/users/jjs/linux-tpmdd.git in
> order to get exposure (tested-by's are always welcome).
>
> > Jason
>
> /Jarkko
>
------------------------------------------------------------------------------
_______________________________________________
tpmdd-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
