> > On Wed, Sep 07, 2016 at 02:32:32PM +0300, Tomas Winkler wrote: > > INIT_LIST_HEAD(&resources); > > - ret = acpi_dev_get_resources(device, &resources, > crb_check_resource, > > - &io_res); > > + ret = acpi_dev_get_resources(device, &resources, > > + crb_check_resource, &io_res); > > Do not randomly reflow unrelated text in patches
It wasn't random, who breaks code like that... > > + /* > > + * PTT HW bug w/a: wake up the device to access > > + * possibly not retained registers. > > + */ > > + ret = __crb_cmd_ready(dev, priv); > > + if (ret) > > + return ret; > > + > > + pa_high = ioread32(&priv->cca->cmd_pa_high); > > + pa_low = ioread32(&priv->cca->cmd_pa_low); > > + cmd_pa = ((u64)pa_high << 32) | pa_low; > > Why change from the original hunk? This is where the bug is visible... I'll put the debug print back it might be useful. > - cmd_pa = ((u64) ioread32(&priv->cca->cmd_pa_high) << 32) | > - (u64) ioread32(&priv->cca->cmd_pa_low); > > > priv->rsp = priv->cmd; > > + > > +out: > > + __crb_go_idle(dev, priv); > > return 0; > > Nope on the return 0.. return ret I guess? Right, good catch. ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
