Am 12. September 2016 00:56:37 GMT-07:00, schrieb Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>: >On Sun, Sep 11, 2016 at 09:39:04PM -0700, Peter Huewe wrote: >> Jarkko, >> what's the ack for? >> As maintainer you usually apply and sign off or don't. >> Ack is more if you are not touching the patch but still think it's >good (e.g.goes through another tree. > >I've based my use of acked-by based on section 12 of > >https://www.kernel.org/doc/Documentation/SubmittingPatches > >Have I somehow misunderstood it? I add signed-off-by's before I send >a pull requst even if the patch contains reviewd/acked-by by me.
Hi, you usually add your signed-off while applying. If you apply the patch you take an active role in forwarding the patch. That's why this section applies: "The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path." " If a person was not directly involved in the preparation or handling of a patch but wishes to signify and record their approval of it then they can ask to have an Acked-by: line added to the patch's changelog. " E.g. Rob would do that for the dt bindings. He does have a quick look at a binding and says "okay for him" by indicating the ACK. So rule of thumb If it goes through your tree or you are the author ->signed off If not -> ack Reviewed-by is a bit unrelated, and content wise stronger as ack, but weaker approval wise. Peter > >/Jarkko > >> @Thomas:thanks for your contribution, but please spellcheck your >descriptions, please. >> >> Am 11. September 2016 13:38:49 GMT-07:00, schrieb Jarkko Sakkinen ><jarkko.sakki...@linux.intel.com>: >> >On Sun, Sep 11, 2016 at 10:22:10PM +0300, Tomas Winkler wrote: >> >> Straighten unneeded line brake and drop useless cast to void. >> >> >> >> Signed-off-by: Tomas Winkler <tomas.wink...@intel.com> >> > >> >Thanks. >> > >> >Acked-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> >> > >> >/Jarkko >> > >> >> --- >> >> drivers/char/tpm/tpm-dev.c | 3 +-- >> >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> >> >> diff --git a/drivers/char/tpm/tpm-dev.c >b/drivers/char/tpm/tpm-dev.c >> >> index 912ad30be585..9782df406345 100644 >> >> --- a/drivers/char/tpm/tpm-dev.c >> >> +++ b/drivers/char/tpm/tpm-dev.c >> >> @@ -130,8 +130,7 @@ static ssize_t tpm_write(struct file *file, >const >> >char __user *buf, >> >> >> >> mutex_lock(&priv->buffer_mutex); >> >> >> >> - if (copy_from_user >> >> - (priv->data_buffer, (void __user *) buf, in_size)) { >> >> + if (copy_from_user(priv->data_buffer, buf, in_size)) { >> >> mutex_unlock(&priv->buffer_mutex); >> >> return -EFAULT; >> >> } >> >> -- >> >> 2.7.4 >> >> >> > >> >>------------------------------------------------------------------------------ >> >_______________________________________________ >> >tpmdd-devel mailing list >> >tpmdd-devel@lists.sourceforge.net >> >https://lists.sourceforge.net/lists/listinfo/tpmdd-devel >> >> -- >> Sent from my mobile -- Sent from my mobile ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel