On Sat, Oct 08, 2016 at 10:42:03AM -0600, Jason Gunthorpe wrote: > On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > > > Rather you it would be better not to use cmdReady/goIdle at all if > > kernel is not compiled with CONFIG_PM. > > It would be best practice to ensure the tpm is powered up no matter > how the kernel is compiled.. The firmware may have left it in idle or > something > > FWIW, I broadly agree there is no need to put the device into idle on > the error paths. It probably wasn't idle when the driver attached to > it.
I'll keep the current commit because it's anyway tested code. If I want to change this I'll send a separate patch for review. > Jason /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
