On Mon, Oct 10, 2016 at 09:43:05AM +0530, Nayna wrote: > > > On 10/10/2016 08:51 AM, Jason Gunthorpe wrote: > >On Mon, Oct 10, 2016 at 07:23:33AM +0530, Nayna wrote: > > > >>And we pass this as private data to i_node in tpm_bios_log_setup. > > > >>So, we are referring chip as i_node->i_private->chip. > > > >That probably works, but you can't use the i_private = NULL scheme I > >outlined with that. > > Why ? we are doing i_private = NULL during teardown to imply that chip > unregister is in progress. and no more securityfs operations should be done. > So, whether chip is NULL or securityfs_data is NULL, either should be ok. > Isn't it ?
How does release() work if you have to do: put_device(&((const struct tpm_securityfs_data *)inode->i_private)->chip.dev) i_private could be null Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
