On Tue, Oct 11, 2016 at 02:23:15PM +0300, Jarkko Sakkinen wrote:
> > >+ chip->bios_dir[cnt] =
> > > securityfs_create_file("ascii_bios_measurements",
> > >- S_IRUSR | S_IRGRP, tpm_dir,
> > >+ S_IRUSR | S_IRGRP, chip->bios_dir[0],
> > > (void *)&tpm_ascii_b_measurments_seqops,
> > > &tpm_bios_measurements_ops);
> > >+ if (is_bad(chip->bios_dir[cnt]))
> > >+ goto err;
> > >+err:
> > >+ chip->bios_dir[cnt] = NULL;
> >
> > The updated patch looks fine.
> > Just, I am not sure if NULL assignment is needed.
>
> It's not needed.
It is required to switch an ERR_PTR to NULL, see is_bad()
The original version that used a counter in chip did not need it.
Jason
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
tpmdd-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
