On 10/10/2016 04:52 AM, Jason Gunthorpe wrote:
> On Sun, Oct 09, 2016 at 07:25:30AM +0530, Nayna wrote:
>
>>> diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
>>> index 22b8f81..1464cae 100644
>>> +++ b/drivers/char/tpm/tpm_of.c
>>> @@ -31,40 +31,34 @@ int read_log_of(struct tpm_chip *chip)
>>> log = &chip->log;
>>> if (chip->dev.parent->of_node)
>>> np = chip->dev.parent->of_node;
>>> - if (!np) {
>>> - pr_err("%s: ERROR - IBMVTPM not supported\n", __func__);
>>> + if (!np)
>>> return -ENODEV;
>>> - }
>
>
>>> sizep = of_get_property(np, "linux,sml-size", NULL);
>>> if (sizep == NULL) {
>>> - pr_err("%s: ERROR - SML size not found\n", __func__);
>>> - goto cleanup_eio;
>>> + dev_dbg(&chip->dev, "%s: ERROR - SML size not found\n",
>>> + __func__);
>>> + return -EIO;
>>> }
>
> The properties are optional (eg my DT bound TPMs on ARM do not have
> them) so I'm not sure the debug is appropriate either...
Hmm.. does that imply that do we even need a msg ?. or probably if
dev_info(..) looks appropriate, this can give the indication that the
platform does not support eventlog, and that is ok.
Thanks & Regards,
- Nayna
>
> Everything else looks OK to me.
>
> Jason
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
